Support for joining Actions in un-reachable GitHub Enterprise Servers via Static JWKS#48973
Merged
strideynet merged 8 commits intomasterfrom Nov 15, 2024
Merged
Support for joining Actions in un-reachable GitHub Enterprise Servers via Static JWKS#48973strideynet merged 8 commits intomasterfrom
strideynet merged 8 commits intomasterfrom
Conversation
github-actions
Bot
requested review from
doggydogworld,
hugoShaka,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
Contributor
|
🤖 Vercel preview here: https://docs-4gtklpkkt-goteleport.vercel.app/docs/ver/preview |
hugoShaka
approved these changes
Nov 14, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
It's interesting how we are adding static JWK for unreachable github enterprise, and dynamic fetching JWKS for EKS clusters with short-lived key-sets 😅
I suppose we'll need to do both each time now.
Do we know how often GHE rotates its JWKS?
Contributor
|
🤖 Vercel preview here: https://docs-5yx8ks8v7-goteleport.vercel.app/docs/ver/preview |
tigrato
approved these changes
Nov 15, 2024
Contributor
tigrato
left a comment
tigrato
left a comment
There was a problem hiding this comment.
I would like to see static_jwks being marshaled as structpb because json in strings doesn't marshal well
public-teleport-github-review-bot
Bot
removed request for
mmcallister,
r0mant,
xinding33 and
zmb3
public-teleport-github-review-bot
Bot
removed request for
doggydogworld and
ptgott
Contributor
|
🤖 Vercel preview here: https://docs-4pq2hkhtp-goteleport.vercel.app/docs/ver/preview |
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Nov 15, 2024
… via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things
ptgott
pushed a commit
that referenced
this pull request
Nov 15, 2024
… via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ervers via Static JWKS (#48973) (#49052) * Support for joining Actions in un-reachable GitHub Enterprise Servers via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things * Fix key generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30831
changelog: Added support for directly configuring JWKS for GitHub joining for circumstances where the GHES is not reachable by the Teleport Auth Service.